Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated behaviour of custom tests using with statements #518

Merged
merged 2 commits into from
Sep 3, 2024
Merged

updated behaviour of custom tests using with statements #518

merged 2 commits into from
Sep 3, 2024

Conversation

cody-scott
Copy link
Collaborator

Switches from searching for with at the beginning of the main_sql statement, to searching for with ... as ( using regex

Added tests to validate behaviour of using with statements in custom tests including statements that begin with comments

Address issue #470

@cody-scott cody-scott mentioned this pull request Aug 23, 2024
Closed
@cody-scott cody-scott changed the title added tests for with statements in custom tests updated behaviour of custom tests using with statements Aug 23, 2024
@cody-scott cody-scott merged commit e8e69c7 into dbt-msft:master Sep 3, 2024
53 checks passed
@cody-scott cody-scott deleted the tests-with-sql branch September 3, 2024 15:05
@cody-scott cody-scott mentioned this pull request Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cody-scott